Skip to content

fix missing generic attrs for svg #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025
Merged

Conversation

patricklx
Copy link
Contributor

fixes #878

@patricklx
Copy link
Contributor Author

I think this should fix the issue. Just need to run script to update elements.d.ts

@NullVoxPopuli
Copy link
Contributor

Just need to run script to update

I ran both and added the changes to this branch

@patricklx patricklx marked this pull request as ready for review April 10, 2025 15:33
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Apr 10, 2025
@NullVoxPopuli NullVoxPopuli merged commit 6e222ff into typed-ember:main Apr 10, 2025
2 checks passed
@johanrd
Copy link
Contributor

johanrd commented Apr 11, 2025

@patricklx Thanks! This seems to fix most namespace cases within svg!

The xlmns attribute is still yelled at with glint 1.4.1-unstable.6e222ff:

Screenshot 2025-04-11 at 08 08 58
<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'> 
  <path d='M16.32 14.9l5.39 5.4a1 1 0 0 1-1.42 1.4l-5.38-5.38a8 8 0 1 1 1.41-1.41zM10 16a6 6 0 1 0 0-12 6 6 0 0 0 0 12z' />
</svg>

Even though xmlns is not required, it should be allowed by glint, or? Edit: When thinking about it more, yelling at unnecessary xmlns may be a good feature to have delegated to glint after all. (not sure though).

@github-actions github-actions bot mentioned this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants